Stop passing symlinks to ImageMagick - #31969
Merged
Merged
Conversation
timhoffm
reviewed
Jun 29, 2026
timhoffm
left a comment
Member
There was a problem hiding this comment.
Why do we need a copy? Can‘t we just resolve the symlink?
Contributor
Author
Whoops, yeah, good point |
Member
|
ImageMagick probably could have come up with a clearer error message for this case... I don't know how you managed to find this out. |
QuLogic
approved these changes
Jun 29, 2026
Contributor
Author
Heh, symbolic links were on my brain because @ksunden said "symbolic link" at the last meeting, so he might have figured it out first, or it was just a happy coincidence |
timhoffm
approved these changes
Jun 29, 2026
5 tasks
QuLogic
pushed a commit
that referenced
this pull request
Jun 29, 2026
QuLogic
added a commit
that referenced
this pull request
Jun 29, 2026
…969-on-v3.11.x Backport PR #31969 on branch v3.11.x (Stop passing symlinks to ImageMagick)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This is an alternative to merging #31954.
When doing an image-comparison test for a GIF, ImageMagick is invoked to convert the expected-image GIF file to PNG, and the expected-image files are actually symbolic links (when possible on the OS). However, the default security policy of ImageMagick (as of a few months back) is to not follow symlinks. For some reason that I do not understand, this causes a problem for us on only one of the CI build environments – even though I see no indication of a different version of ImageMagick or a non-default security policy – but I suspect other CI builds could fail in the future. As a fix and preventative measure, this PR
makes a copy of any symlinked filesimply resolves any symlink before passing it on to ImageMagick.AI Disclosure
No AI was used
PR checklist