Break out gif test so it can be XFailed on Azure - #31954
Closed
ksunden wants to merge 1 commit into
Closed
Conversation
QuLogic
reviewed
Jun 26, 2026
Comment on lines
+49
to
+50
| @image_comparison(baseline_images=['agg_filter_alpha'], | ||
| extensions=['gif'], style='mpl20') |
Member
There was a problem hiding this comment.
Note, you can just write a single extension together:
Suggested change
| @image_comparison(baseline_images=['agg_filter_alpha'], | |
| extensions=['gif'], style='mpl20') | |
| @image_comparison(baseline_images=['agg_filter_alpha.gif'], style='mpl20') |
Member
Author
There was a problem hiding this comment.
In this instance, I think I prefer it the way I have it, as that keeps it more consistent with the other test, and keeps the reversal idea easier to see.
Update condition on xfail
Member
|
Superseded by #31969. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This test has been consistently failing on exactly one CI setup.
I've been unable to reproduce it locally, so XFailing the test specific to that CI setup.
I'd like to actually fix the underlying problem, but for now, limiting the amount of "it's red but we can ignore that" is better.
AI Disclosure
None
PR checklist