Simplify circular default value validation - #4460
Open
andimarek wants to merge 2 commits into
Open
Conversation
Port the focused cleanup from the 26.x backport in #4450 to master.
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (3 classes)
|
Keep the higher-level SDL and argument-default regression tests on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the core circular-default validation simplifications from the merged 26.x backport in #4450 to master while retaining all existing master integration coverage.
Analysis
The master implementation still had separate AST and external-value algorithms, retained validation-rule state across runs, and could reach external-value coercion before a circular default had been recorded. The #4450 implementation cleanup removes those failure modes and reduces the focused implementation and lower-level test code by 75 net lines.
Unlike #4450, this PR intentionally preserves CircularInputDefaultValuesTest so the higher-level schema-build coverage and explicit SDL argument-default regression remain in place.
Testing
All passed on Java 25.