Backport 26.1: validate circular default values - #4450
Merged
Conversation
* init * improve spec alignment * Avoid unnecessary circular default validation work --------- Co-authored-by: Andreas Marek <andimarek@fastmail.fm>
Contributor
Test ReportTest Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4253 to the
26.xmaintenance branch.Input object fields can define default values in ways that form cycles. For example:
The defaults form an infinitely expanding value. This PR implements the specification
InputObjectDefaultValueHasCyclevalidation so these schemas are rejected during schema validation instead of overflowing while defaults are coerced.Implementation notes:
This behavior matches the GraphQL specification and graphql-js v17 implementation: