Invalid issue raised - #6447
Closed
ruchirmehta07 wants to merge 85 commits into
Closed
Conversation
* Created new persistence algorithm * Update persistence.py * Added another persistence function
* makes LRUCache constructor concrete * fixes bug in dq_removal in other/least_recently_used + deque.remove() operates by value not index * [mypy] Annotates other/least_recently_used over generic type + clean-up: rename key_reference to match type. * [mypy] updates example to demonstrate LRUCache with complex type * Adds doctest to other/least_recently_used * mypy.ini: Remove exclude = (other/least_recently_used.py) * Various mypy configs * Delete mypy.ini * Add mypy to .pre-commit-config.yaml * mypy --ignore-missing-imports --install-types --non-interactive . * mypy v0.910 * Pillow=8.3.7 * Pillow==8.3.7 * Pillow==8.3.2 * Update .pre-commit-config.yaml * Update requirements.txt * Update pre-commit.yml * --install-types # See mirrors-mypy README.md Co-authored-by: Christian Clauss <cclauss@me.com>
* adding pooling algorithms * pooling.py: Adding pooling algorithms to computer vision pull_number= * pooling.py: Adding pooling algorithms to computer vision * pooling_functions.py: Adding pooling algorithms to computer vision * pooling.py: Adding Pooling Algorithms * pooling_functions.py Add and Update * Update pooling_functions.py * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update computer_vision/pooling_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update pooling_functions.py * Formatting pooling.py Co-authored-by: Christian Clauss <cclauss@me.com>
* Replace typing.optional with new annotations syntax
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Updated the comments in the code * Update .gitignore * Update .gitignore * Update .gitignore Co-authored-by: Christian Clauss <cclauss@me.com>
* Added memoization function in fibonacci * Minor changes
* Update merge_insertion_sort.py Fixes #5774 merge_insertion_sort Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Update merge_insertion_sort.py Fixes #5774 merge_insertion_sort Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Update merge_insertion_sort.py Fixes #5774 added permutation range from 0 to 4 Co-Authored-By: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> * Use `all()` Co-authored-by: AilisOsswald <44617437+AilisOsswald@users.noreply.github.com> Co-authored-by: John Law <johnlaw.po@gmail.com>
* Syntax improvements (I hope) to boolean algebra * Reverted certain index variables to i * remove extra line on decimal_to_binary * Update quine_mc_cluskey.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* ci: add mkdir step for mypy
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Update currency_converter.py
* refactor: add types and remove reserved keyword "from" usage
* feat: update text
* Update web_programming/currency_converter.py
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
* Update web_programming/currency_converter.py
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
* fix: update currency_converter.py
* updating DIRECTORY.md
* Update currency_converter.py
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
* The black formatter is no longer beta
* pre-commit autoupdate
* pre-commit autoupdate
* Remove project_euler/problem_145 which is killing our CI tests
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
… drug name and zipcode (#5967) * add wellrx scraping * write test fix docs * fix resolve issues * black format. fix returns * type check fix for union * black formatted * Change requests after code review * add precommit changes * flake errors
…5975) * fetch anime * formatted code * fix format errors * fix bot reviews * pr review fixes * remove unussed exception * change var name * fix comments
* Upgrade to Python 3.10
* Upgrade to Python 3.10
* mypy || true
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* pyupgrade --py310-plus and run mypy in precommit, not build * pyupgrade --py310-plus web_programming/fetch_well_rx_price.py * pyupgrade --py310-plus web_programming/fetch_well_rx_price.py * Fix arithmetic_analysis/in_static_equilibrium.py * Fix arithmetic_analysis/in_static_equilibrium.py
* Add points are collinear in 3d algorithm to /maths * Apply suggestions from code review in points_are_collinear_3d.py Thanks to cclauss. Co-authored-by: Christian Clauss <cclauss@me.com> * Rename some variables to be more self-documenting. * Update points_are_collinear_3d.py Co-authored-by: Christian Clauss <cclauss@me.com>
* Added average absolute deviation * Formats program with black * reruns updated pre commit * Update average_absolute_deviation.py Co-authored-by: Christian Clauss <cclauss@me.com>
* 📝 Updated year Fixes: #5916 * Update LICENSE.md Co-authored-by: John Law <johnlaw.po@gmail.com>
black==22.1.0 is breaking the hook. Updating it to 22.3.0 fixes all the issue Refer: python-poetry/poetry#5375
* feat: added ngram algorithm * fix(test): use `math.isclose` to match floating point numbers approximately Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
* Add files via upload * Changed print to f-string Also printed out results in a math notation * Add files via upload * Fixes: #4710 provided return type * File exists in another pull request * imported radians from math * Updated file according to pre-commit test * Updated file * Updated gamma * Deleted duplicate file * removed pi * reversed tests * Fixed angle condition * Modified prints to f-string * Update horizontal_projectile_motion.py * Update horizontal_projectile_motion.py * Fixes #4710 added exceptions and tests * Added float tests * Fixed type annotations * Fixed last annotation * Fixed annotations * fixed format * Revert "fixed format" This reverts commit 5b0249a. Undo changes @wq * Revert "Fixed annotations" This reverts commit c37bb95. * Revert "Fixed last annotation" This reverts commit e3678fd. * Revert "Fixed type annotations" This reverts commit 3f2b238. * Revert to 4e2fcaf * Fixing errors found during pre-commit
* Fixes (#5434) * Update ciphers.rabin_miller.py maths.miller_rabin.py * Fixing ERROR maths/miller_rabin.py - ModuleNotFoundError and changing project_euler's isPrime to is_prime function names * Update sol1.py * fix: try to change to list * fix pre-commit * fix capital letters * Update miller_rabin.py * Update rabin_miller.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Fix quicksort doc * add binary tree traversals doc * Add link to the reference * Fix job * Change url * Update binary_tree_traversals.md * Update normal_distribution_quick_sort.md * Update normal_distribution_quick_sort.md Co-authored-by: John Law <johnlaw.po@gmail.com>
* First commit for add_prefix_conversion * Class names in CamelCase, str.format() to f-string * Fixed following pre-commit guidelines * solved issues with mypy and enum.Enum * Rename add_prefix_conversion.py to prefix_conversions_string.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Fix some typos. * Update volume.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* fix black at prefix string * Type -> type * Type unused
* Solution to Problem 145 of Project Euler * Provided more descriptive filename * Update sol1.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Hacktoberfest: added sol for P104 Project Euler * bot requests resolved * pre-commit * Update sol.py * Update sol.py * remove trailing zeroes * Update sol.py * Update sol.py * Update sol.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Added implementation of the Horn-Schunck algorithm * Cleaner variable names * added doctests * Fix doctest * Update horn_schunck.py * Update horn_schunck.py * Update horn_schunck.py * Update horn_schunck.py Co-authored-by: John Law <johnlaw.po@gmail.com>
As described in CONTRIBUTING.md > Expand acronyms because gcd() is hard to understand but greatest_common_divisor() is not. Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Improve solution (locally 3+ times - from 3+ seconds to ~1 second)
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Improve solution (locally 1500+ times - from 3+ seconds to ~2 milliseconds)
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* Add `MaxFenwickTree` * Reformat code style * Fix type hints * Fix type hints again * Complete docstring * Complete docstring * Fix typo in file name * Change MaxFenwickTree into 0-based indexing * Fix Bugs * Minor fix
* Enhance fenwick_tree.py * Change update to add in fenwick_tree.py * Some changes * Fix bug * Add O(N) initializer to FenwickTree * Add get method to Fenwick Tree * Change tree in Fenwick Tree * Add rank query to FenwickTree * Add get_array method to FenwickTree * Add some tests * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update data_structures/binary_tree/fenwick_tree.py Co-authored-by: Christian Clauss <cclauss@me.com> * change `List` to `list` Co-authored-by: Christian Clauss <cclauss@me.com>
* add algorithm local binary pattern
* fix failed test for local binary pattern
* updating DIRECTORY.md
* fix detected precommit-error
* fix precommit error
* final check
* Add descriptive name for parameters x and y
* Update digital_image_processing/filters/local_binary_pattern.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update digital_image_processing/filters/local_binary_pattern.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update digital_image_processing/filters/local_binary_pattern.py
Co-authored-by: Christian Clauss <cclauss@me.com>
* Update local_binary_pattern.py
* undo changes made on get_neighbors_pixel()
* files formatted by black
* Update digital_image_processing/filters/local_binary_pattern.py
ok thanks
Co-authored-by: Christian Clauss <cclauss@me.com>
* add test for get_neighbors_pixel() function
* reviewed
* fix get_neighbors_pixel
* Update test_digital_image_processing.py
* updating DIRECTORY.md
* Create code_quality.yml
* Create code_quality.yml
* Delete code_quality.yml
* Update code_quality.yml
* Delete code_quality.yml
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
* adding the dna algorithm * following bot recommendations following bot recommendations for the indentation * following bot recommendations following bot recommendations regarding indentation [ again ] * following bot recommendations following bot recommendations regarding indentation [ again. ] * following bot recommendations following bot recommendations.
* fixes #5434 * fixes broken solution * removes assert * removes assert * Apply suggestions from code review Co-authored-by: John Law <johnlaw.po@gmail.com> * Update project_euler/problem_003/sol1.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Add Optimized Shell Sort * Added return type * reformatted * added shrink_shell.py * ran directory generator * Rename shrink_shell.py to shrink_shell_sort.py Co-authored-by: John Law <johnlaw.po@gmail.com>
* Fix minor typo in comment * Add matrix dimension check * Add descriptive comment
* Add solution
* updating DIRECTORY.md
* Fix pre-commit
* updating DIRECTORY.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
ruchirmehta07
requested review from
Kush1101,
cclauss and
dhruvmanila
as code owners
October 1, 2022 08:57
Closing this pull request as invalid@iteratorr, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,

I observed that the below issue raised is invalid and doesn't comply with the guidelines and should be marked as invalid/resolved.
#6377