Skip to content

Hacktoberfest: added sol for P104 Project Euler - #5257

Merged
poyea merged 10 commits into
TheAlgorithms:masterfrom
Enkryp:eulerp104
May 2, 2022
Merged

Hacktoberfest: added sol for P104 Project Euler#5257
poyea merged 10 commits into
TheAlgorithms:masterfrom
Enkryp:eulerp104

Conversation

@Enkryp

@Enkryp Enkryp commented Oct 12, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Oct 12, 2021

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread project_euler/problem_104/sol.py Outdated
Comment thread project_euler/problem_104/sol.py Outdated

'''

checkLast=[0]*11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: checkLast

Comment thread project_euler/problem_104/sol.py Outdated
'''

checkLast=[0]*11
checkFront=[0]*11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: checkFront

Comment thread project_euler/problem_104/sol.py Outdated



def check1(a : int) ->bool:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: a

Comment thread project_euler/problem_104/sol.py Outdated

'''

checkLast=[0]*11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: checkLast

@ghost ghost added tests are failing Do not merge until tests pass and removed require descriptive names This PR needs descriptive function and/or variable names labels Oct 12, 2021
@Enkryp

Enkryp commented Oct 17, 2021

Copy link
Copy Markdown
Contributor Author

Hi! @Kush1101 @dhruvmanila could you please run the tests and workflows again and give a review, I have fixed the pre commit issues.

@poyea

poyea commented Oct 21, 2021

Copy link
Copy Markdown
Member

Please see and wait for #5496.

@stale

stale Bot commented May 2, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label May 2, 2022
@stale stale Bot removed the stale Used to mark an issue or pull request stale. label May 2, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label May 2, 2022

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 2, 2022
@poyea
poyea merged commit 26f2df7 into TheAlgorithms:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants