Document GitHub agent permissions and the GitHub tool surface - #35
Open
tpavlu wants to merge 2 commits into
Open
Document GitHub agent permissions and the GitHub tool surface#35tpavlu wants to merge 2 commits into
tpavlu wants to merge 2 commits into
Conversation
Word-level pass toward simplified technical English. Swaps requires/required and previous for their plainer equivalents on lines this PR introduced. No technical content or product names changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Three pages gestured at a GitHub permission that decides whether Ref may merge on your behalf ("if permitted", "depends on your GitHub permissions settings") without ever naming it or saying where it lives. This adds an Agent permissions section to the GitHub integration page that names the three toggles, their defaults, and the personal-access-token requirement for merging. It also moves the GitHub MCP tool list off the Plans MCP install page — where nobody reading about the GitHub integration would look — onto the GitHub page, and leaves a short pointer plus the endpoint URL behind on the install page.
Moved rather than mirrored so the tool list has one home and can't drift; the install page keeps the endpoint and the connection prerequisites, since that is what someone configuring a client needs there.
Verified
All in
ref-tools/ref:plan-app/client/src/components/settings/GitHubSettingsPage.tsx: labels "GitHub Enabled", "Allow PR Reviews", "Allow PR Merges"; the latter two sit under the "PR & Issue Actions" group header.plan-app/client/src/components/settings/SettingsModal.tsxrenders it as the sidebar nav item labelled "GitHub" in the Settings modal.plan-app/server/src/types/agentLaunch.ts:isGitHubEnabledandisGitHubReviewEnabledare!== false(on by default),isGitHubMergeEnabledis=== true(off by default). The client initialises the same three defaults.OrchestratorSettingsdocuments that merge permission lives ingithub.mergeEnabled.plan-app/client/src/utils/orchestrate.tsxbuildKickoffPromptemits "Do not merge; leave merging to a human." when it is off, which is the basis for the sentence about an orchestrating agent.GitHubSettingsPage.tsxdisables the merge toggle unless a PAT is connected and links to/resources?tab=github&action=connect-pat(which resolves to the main domain, i.e. ref.tools/resources, viaplan-app/client/src/lib/navigation.ts). Server side,plan-app/server/src/routes/github-mcp-handlers.tshandlePRsMergerejects any token whose source is notpersonal-token.plan-app/server/src/routes/github-mcp.ts:GetIssue,CommentOnIssue,SearchIssues,ReadPR,SearchPRs,CreatePRalways registered;ReviewPRregistered only when reviews are enabled;MergePRregistered only when at least one of reviews/merges is enabled, withmark_readygated on reviews andmergegated on merges.ReadPRactions are get / get_files / get_diff / get_comments.CreatePRtakes adraftflag.CreatePRwas missing from the previous docs list and is now included.github-mcp.tsreturns 403 "GitHub access is disabled in Settings." at session initialisation whenenabledis false, so the tools never connect.github-mcp.tsre-reads settings viagetGitHubSettings(userId)inside theReviewPRandMergePRhandlers, andhandlePRsReview/handlePRsMarkReady/handlePRsMergeeach re-assert the permission.plan-app/server/src/index.tsmounts the router at/github-mcp;https://api.plan.ref.toolsis the production plan API host.Unverified / omitted
MergePRmerge methods (merge / squash / rebase, defaulting to merge) — verified in code but left out to keep the tool table at one line per tool.your-first-plan.mdxand the "(if permitted)" aside inmulti-agent.mdxwere left untouched; both are now explained by the new section, but editing them is outside this change's scope.Conflicts
docs.jsonwas not edited — no new pages, so no navigation change. No conflicts expected with sibling PRs beyond ordinary text merges inplans/install/index.mdx.Generated by Claude Code