Skip to content

bpo-34814: Fix Modules/makesetup for shared libraries #9593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

bpo-34814: Fix Modules/makesetup for shared libraries #9593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2018-09-26-18-57-43.bpo-34814.tv7fIY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix Modules/makesetup script for shared libraries. When Modules/Setup is
modified to compile C extensions as shared libraries using Makefile, make
sure that the generated shared library is linked to libpython3.X.
4 changes: 2 additions & 2 deletions Modules/makesetup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ sed -e 's/[ ]*#.*//' -e '/^[ ]*$/d' |
case $doconfig in
no) SHAREDMODS="$SHAREDMODS $file";;
esac
rule="$file: $objs"
rule="$rule; \$(BLDSHARED) $objs $libs $ExtraLibs -o $file"
rule="$file: $objs \$(LDLIBRARY)"
rule="$rule; \$(BLDSHARED) $objs \$(BLDLIBRARY) $libs $ExtraLibs -o $file"
echo "$rule" >>$rulesf
done
done
Expand Down