bpo-33617: Use os.fspath() for subprocess sequences on Windows - #7071
Closed
altendky wants to merge 1 commit into
Closed
bpo-33617: Use os.fspath() for subprocess sequences on Windows#7071altendky wants to merge 1 commit into
altendky wants to merge 1 commit into
Conversation
Contributor
Author
|
https://travis-ci.org/python/cpython/jobs/382707216#L8506-L8522 ======================================================================
FAIL: test_stdin_broken_pipe (test.test_asyncio.test_subprocess.SubprocessFastWatcherTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_asyncio/test_subprocess.py", line 238, in test_stdin_broken_pipe
self.loop.run_until_complete, coro)
AssertionError: (<class 'BrokenPipeError'>, <class 'ConnectionResetError'>) not raised by run_until_complete
======================================================================
FAIL: test_stdin_broken_pipe (test.test_asyncio.test_subprocess.SubprocessSafeWatcherTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_asyncio/test_subprocess.py", line 238, in test_stdin_broken_pipe
self.loop.run_until_complete, coro)
AssertionError: (<class 'BrokenPipeError'>, <class 'ConnectionResetError'>) not raised by run_until_complete
----------------------------------------------------------------------I ran this locally 10x and didn't get the errors. Is there a place where flaky tests are tracked that I could check? Otherwise I'll try making my own Travis build of it to see if I can recreate it. ~/cpython 33617-subprocess_pathlike_in_sequence ./python -m test -j3 test_asyncio.test_subprocess
Run tests in parallel using 3 child processes
0:00:04 load avg: 3.28 [1/1] test_asyncio.test_subprocess passed
1 test OK.
Total duration: 5 sec
Tests result: SUCCESS |
Member
|
This has been implemented in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33617