Skip to content

bpo-31160: test_tempfile: Fix reap_children() warning #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Aug 10, 2017
Merged

bpo-31160: test_tempfile: Fix reap_children() warning #3056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def setUp(self):
def tearDown(self):
self._warnings_manager.__exit__(None, None, None)


def nameCheck(self, name, dir, pre, suf):
(ndir, nbase) = os.path.split(name)
npre = nbase[:len(pre)]
Expand Down Expand Up @@ -184,12 +183,15 @@ def test_process_awareness(self):
try:
pid = os.fork()
if not pid:
# child process
os.close(read_fd)
os.write(write_fd, next(self.r).encode("ascii"))
os.close(write_fd)
# bypass the normal exit handlers- leave those to
# the parent.
os._exit(0)

# parent process
parent_value = next(self.r)
child_value = os.read(read_fd, len(parent_value)).decode("ascii")
finally:
Expand All @@ -200,6 +202,10 @@ def test_process_awareness(self):
os.kill(pid, signal.SIGKILL)
except OSError:
pass

# Read the process exit status to avoid zombie process
os.waitpid(pid, 0)

os.close(read_fd)
os.close(write_fd)
self.assertNotEqual(child_value, parent_value)
Expand Down