Skip to content

bpo-35306: Handle '*' in pathlib.Path functions on Windows #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladima wants to merge 2 commits into from
Closed

bpo-35306: Handle '*' in pathlib.Path functions on Windows #11133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352c106
Fix for bpo35306: handle '*' in pathlib.Path functions on Windows
vladima Dec 12, 2018
846e701
drop trailing whitespace
vladima Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@
# Internals
#

# EBADF - guard agains macOS `stat` throwing EBADF
_IGNORED_ERROS = (ENOENT, ENOTDIR, EBADF)
# EBADF - guard against macOS `stat` throwing EBADF
# EINVAL - `stat` on Windows throws it for invalid paths
_IGNORED_ERROS = (ENOENT, ENOTDIR, EBADF, EINVAL)

def _is_wildcard_pattern(pat):
# Whether this pattern needs actual matching using fnmatch, or can
Expand Down
3 changes: 3 additions & 0 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2242,6 +2242,9 @@ def test_rglob(self):
p = P(BASE, "dirC")
self.assertEqual(set(p.rglob("FILEd")), { P(BASE, "dirC/dirD/fileD") })

def test_exists_for_invalid_path(self):
self.assertEqual(self.cls("*").exists(), False)

def test_expanduser(self):
P = self.cls
with support.EnvironmentVarGuard() as env:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-12-12-12-09-27.bpo-35306.AzA3I6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle '*' in pathlib.Path.exists on Windows