MAINT: remove numpy.distutils - #30340
Conversation
| @@ -1,219 +0,0 @@ | |||
| .. _numpy-distutils-refguide: | |||
There was a problem hiding this comment.
Should this be a stub so outside links are not broken?
There was a problem hiding this comment.
Hmm, don't know. Who might have links?
There was a problem hiding this comment.
I checked SciPy, they don't.
| default keyword-only argument specifies an object to return if | ||
| the provided iterable is empty. | ||
| With two or more arguments, return the largest argument. | ||
| With two or more ...arguments, return the largest argument. |
There was a problem hiding this comment.
Not needed for the deprecation, but is needed for a different error message on Python3.14
There was a problem hiding this comment.
Needs a space before "arguments".
There was a problem hiding this comment.
No, then the old formatting breaks. The two messages are
With two or more arguments, return the largest argument
vs
With two or more positional arguments, return the largest argument
If I add a space on either side, then the old message fails since it does not have two spaces.
|
I just noticed that it's 22k LOC 🤯 |
|
close/reopen |
|
Looks like you need to rebase this to get circleci to run with Python 3.12. |
4f99915 to
47b8b3c
Compare
|
Rebased |
|
Can confirm that circleci ran with Python 3.12. |
| "--fcompiler cannot be used with meson," | ||
| "set compiler with the FC environment variable\n" | ||
| ) | ||
| for s in del_list: |
There was a problem hiding this comment.
Yeah, this all needs a cleanup but I would prefer to leave it for #30353
| "--fcompiler cannot be used with meson," | ||
| "set compiler with the FC environment variable\n" | ||
| ) | ||
| for s in del_list: |
There was a problem hiding this comment.
Yeah, this all needs a cleanup but I would prefer to leave it for #30353
|
I repurposed
|
|
Let's get this in. Thanks Matti. |
Remove numpy.distutils after the 2.5 branch
numpy.distutils/conv_template.pytonumpy/_build_utils/conv_template.pynumpy/distutils/checkstonumpy/_core/src/_simd/checksThe tricky part was removing the
f2py/_backendand adjusting thef2pyescript. I tried to checkspin docs,spin test,spin check-docs,spin check-tutorials.