Skip to content

Be greedier when checking for tuples or lists. - #6

Merged
methane merged 1 commit into
msgpack:masterfrom
steeve:patch-2
Feb 16, 2012
Merged

Be greedier when checking for tuples or lists.#6
methane merged 1 commit into
msgpack:masterfrom
steeve:patch-2

Conversation

@steeve

@steeve steeve commented Feb 16, 2012

Copy link
Copy Markdown
Contributor

Lots of objects implement iter and len. But that doesn't mean we should treat them as lists!
Limit msgpack arrays to tuples and lists.

@methane

methane commented Feb 16, 2012

Copy link
Copy Markdown
Member

You're right. Users should be able to hook packing objects implements sequence protocol.

methane added a commit that referenced this pull request Feb 16, 2012
Be greedier when checking for tuples or lists.
@methane
methane merged commit 3a472b1 into msgpack:master Feb 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants