ci: Make eslint check fail on errors - #32183
Merged
Merged
Conversation
In matplotlib#32148, the eslint check posted errors, but the job did not fail. This setting ensure that it _will_ fail when it posts errors.
ksunden
approved these changes
Aug 7, 2026
5 tasks
timhoffm
pushed a commit
that referenced
this pull request
Aug 9, 2026
timhoffm
added a commit
that referenced
this pull request
Aug 9, 2026
…183-on-v3.11.x Backport PR #32183 on branch v3.11.x (ci: Make eslint check fail on errors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In #32148, the eslint check posted errors, but the job did not fail. This setting ensure that it will fail when it posts errors.
AI Disclosure
None
PR quality check