Skip to content

TYP: annotate **kwargs in tripcolor overloads - #32106

Open
Aniketsy wants to merge 1 commit into
matplotlib:mainfrom
Aniketsy:type-1
Open

TYP: annotate **kwargs in tripcolor overloads#32106
Aniketsy wants to merge 1 commit into
matplotlib:mainfrom
Aniketsy:type-1

Conversation

@Aniketsy

@Aniketsy Aniketsy commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR summary

  • while looking into typestats coverage dashboard for matplotlib (https://jorenham.github.io/typestats/dashboard/report/#matplotlib) . I find missing annotation in matplotlib.tri._tripcolor was reported as 13/14 typed
  • This PR adds **kwargs: Any to all four overloads in lib/matplotlib/tri/_tripcolor.pyi
  • I'd be happy to submit more PRs if members are accepting improvement in type coverage.

Towards #32157

AI Disclosure

  • No AI

PR checklist

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@Aniketsy

Aniketsy commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

hi @melissawm 😊 if you're are accepting improvement in type coverage. I'd be love to contribute more maybe help to improve coverage from 76 to 100 % in matplotlib.

@Aniketsy Aniketsy mentioned this pull request Jul 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

first-contribution topic: tri topic: typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aniketsy @melissawm