Resolve C++ nullptr issues and move away from deprecated C API usages in relation to #31424 - #32065
Resolve C++ nullptr issues and move away from deprecated C API usages in relation to #31424#32065clin1234 wants to merge 2 commits into
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
6e1ed1d to
03e3c94
Compare
a44a307 to
2ed73b3
Compare
7095fc2 to
6b1521a
Compare
|
Much of this conflicts with #30291 and ft2font-shared_ptr; it wasn't merged for 3.11 because pybind11 v3 was deemed too new at the time. |
86ac426 to
18ebea2
Compare
Would you be willing to rebase your tf2font-shared_ptr branch onto my PR branch? Afaik, you haven't made a PR from that shared_ptr branch yet |
18ebea2 to
c713f7e
Compare
- Replace inline with constexpr where applicable, NULL -> nullptr, and mark unused parameters [[maybe_unused]] - Report FreeType failures via THROW_FT_ERROR instead of generic messages - Check PyOS_double_to_string for failure and detect width*height overflow when allocating FT2Image - Use PyErr_GetRaisedException/PyErr_SetRaisedException (3.12+) in close_file_callback and release py_file there - Return unique_ptr from PyFT2Font_init; delete QhullInfo copy ops; add PathIterator copy-assignment Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PR summary
Attempt to fix (most) trivial C++ bugs found in #31424 during a sprint in SciPy 2026.