Skip to content

Convert macOS backend to ARC #31855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greglucas merged 9 commits into from
Jul 24, 2026
+164 −229
Merged

Convert macOS backend to ARC #31855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e11758b
Convert macOS backend to ARC
iccir Jun 7, 2026
8fd5e75
Assume minimum version of macOS 10.14
iccir Jun 8, 2026
605ced1
Rework window closing
iccir Jun 9, 2026
dc57723
Remove stray log.
iccir Jun 12, 2026
fc570ac
Fixing potential crash with -convertKeyEvent:
iccir Jun 13, 2026
f3752dc
Merge remote-tracking branch 'origin/main' into arc
iccir Jun 27, 2026
d9fd9ba
MACOSX_DEPLOYMENT_TARGET to 10.14
iccir Jun 27, 2026
80a4327
Adding additional fix for #32019
iccir Jul 10, 2026
213618b
Merge branch 'main' into arc
greglucas Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/matplotlib/backends/backend_macosx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from .backend_agg import FigureCanvasAgg
from matplotlib.backend_bases import (
_Backend, FigureCanvasBase, FigureManagerBase, NavigationToolbar2,
ResizeEvent, TimerBase, _allow_interrupt)
CloseEvent, ResizeEvent, TimerBase, _allow_interrupt)


class TimerMac(_macosx.Timer, TimerBase):
Expand Down Expand Up @@ -161,7 +161,10 @@ def __init__(self, canvas, num):
self.show()
self.canvas.draw_idle()

def _close_button_pressed(self):
def _handle_window_will_close(self):
CloseEvent("close_event", self.canvas)._process()

def _handle_window_should_close(self):
Gcf.destroy(self)
self.canvas.flush_events()

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ test-command = [
test-environment = "PIP_PREFER_BINARY=true"

[tool.cibuildwheel.macos.environment]
MACOSX_DEPLOYMENT_TARGET = "10.13"

@QuLogic QuLogic Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a new requirement, it needs an API note; see #32061

@iccir iccir Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuLogic - Got it, I'll make a PR.

MACOSX_DEPLOYMENT_TARGET = "10.14"

[tool.cibuildwheel.pyodide]
test-requires = "pytest"
Expand Down
Loading
Loading