MNT: move ArtistList into artist module - #31794
Conversation
timhoffm
left a comment
There was a problem hiding this comment.
Thanks, much easier to review 😄.
As expected, the doc failure is the same strange inheritance-diagram related failure as in the other PR.
a9d220f to
8e05633
Compare
|
Force-pushed because I also needed to rename the changenote filename, and I wanted that in the first commit. |
|
Notes on second commit for second reviewer: For some reason, modifying the To fix it, I went ahead and added docs for the missing private artists. For For |
QuLogic
left a comment
There was a problem hiding this comment.
I will note that all the doc problems were already listed in doc/missing-references.json, but at a different line number. So if you've fixed them, then you should remove the entries from there.
| @@ -0,0 +1,3 @@ | |||
| The ``Axes.AxesList`` attribute | |||
| def pprint_getters(self) -> list[str]: ... | ||
|
|
||
|
|
||
| class ArtistList(Sequence[_T_Artist]): |
Ah, I didn't know about that file! I had hit the same docs failures after I modified |
|
I had heard of that file but never made the effort to learn what it's about! Thanks @QuLogic it's good to have an explanation. |
|
I am in two minds what to do about the |
8e05633 to
b28308f
Compare
b28308f to
74ea04e
Compare
PR summary
Make
ArtistLista standalone class in theartistmodule, and deprecate accessing as an attribute of the axes class. This is pulled out of #31746 to make the review easier. The only changes to theAxesListclass are__init__call sequence is now on one lineisinstancecall in__add__now checks forArtistListinstead ofAxes.ArtistListI suspect this will need the second commit from #31746, but I'm curious to actually see the doc failure.
AI Disclosure
No AI used.
PR checklist