Use antialiasing when comparing pdf files - #30068
Conversation
Render at 600dpi and scale down to 150dpi.
6afa531 to
645322b
Compare
Perhaps this is causing the EPS failures
|
I didn't check, but did all the baselines get updated because they were in fact already slightly invalid but the errors were hidden by the low resolution? If so, does it mean that the regeneration of most baselines arising from the current work to update freetype & parts of the text rendering stack would mean that after they get merged (perhaps not so quickly...), this PR would no longer need to further update them? Perhaps as a temporary workaround (to limit baseline updates) we could have two test formats, ".pdf" and ".aa600.pdf" where only the latter would be tested after AA rasterization at 600dpi? |
|
Given the bugginess in #31928, I think this is important to get in to avoid additional misinterpreted PDFs. I tried rebasing and regenerating the images, but confusingly, many of the PDFs that didn't match were ones that were recently regenerated for the text overhaul. As it hasn't been that long since we merged that, I'm uncertain why so many should not match all of a sudden. |
Render at 600dpi and scale down to 150dpi.
The low-resolution non-antialiased rendering is convenient in that it hides minor font differences, but it can hide actual rendering errors and cause problems. For example, #29392 needs to change multiple baseline files because of minor differences only visible because of the low-resolution rasterisation.