DOC: Emphasize artist as annotation in AnnotationBbox demo and add to annotation guide - #29374
Merged
Merged
Conversation
story645
force-pushed
the
annotationbbox
branch
2 times, most recently
from
December 23, 2024 05:35
04e428f to
91d2558
Compare
timhoffm
reviewed
Dec 29, 2024
story645
marked this pull request as draft
January 21, 2025 05:02
Member
Author
|
putting back to draft cause dunno when I'll get around to documenting offsetImage and BboxImage |
story645
force-pushed
the
annotationbbox
branch
from
January 21, 2025 05:03
91d2558 to
cc76e51
Compare
story645
force-pushed
the
annotationbbox
branch
from
February 5, 2026 23:20
cc76e51 to
0821495
Compare
Member
Author
6 tasks
story645
force-pushed
the
annotationbbox
branch
from
February 6, 2026 01:13
0821495 to
67fa746
Compare
story645
marked this pull request as ready for review
February 6, 2026 01:13
Member
Author
|
Um, I'm somewhat guessing that zoom here behaves the same way as zoom in matlab (and that it may have been renamed magnification in other functions). |
story645
force-pushed
the
annotationbbox
branch
from
February 6, 2026 21:26
67fa746 to
9ac1333
Compare
timhoffm
reviewed
Feb 7, 2026
timhoffm
reviewed
Feb 7, 2026
story645
force-pushed
the
annotationbbox
branch
2 times, most recently
from
February 9, 2026 02:47
51ea1ef to
a68376e
Compare
timhoffm
approved these changes
Feb 9, 2026
timhoffm
left a comment
Member
There was a problem hiding this comment.
Take or leave my suggestion.
story645
force-pushed
the
annotationbbox
branch
from
February 9, 2026 20:23
a68376e to
829045a
Compare
QuLogic
reviewed
Feb 14, 2026
story645
force-pushed
the
annotationbbox
branch
from
February 15, 2026 23:55
530dbe1 to
37dc59d
Compare
story645
force-pushed
the
annotationbbox
branch
from
February 15, 2026 23:59
37dc59d to
c8dd1b9
Compare
story645
force-pushed
the
annotationbbox
branch
from
February 16, 2026 00:00
c8dd1b9 to
e24508d
Compare
to annotation guide, and documents the OffsetImage class Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
story645
force-pushed
the
annotationbbox
branch
from
February 16, 2026 00:02
e24508d to
c58e81a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Motivated by wanting to position an image relative to text and being confused, I reworked the AnnotationBBox demo:
Also added AnnotationBbox to the Annotation guide because it's currently not there. And documented offsetimagebox per @timhoffm's review.
Current docs:
ETA: AI disclosure
Used AI as fancy grep for dpi_cor and zoom.
PR checklist