Fix backend tests on CI - #26005
Merged
Merged
Conversation
This version is buggy with respect to signals, and causes tests to fail: - https://bugreports.qt.io/projects/PYSIDE/issues/PYSIDE-2346 - https://bugreports.qt.io/projects/PYSIDE/issues/PYSIDE-2348
This is a re-application of matplotlib#23095, but with some more specific conditions. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
timhoffm
approved these changes
May 30, 2023
oscargus
approved these changes
May 30, 2023
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 1, 2023
(cherry picked from commit 330969c)
QuLogic
added a commit
that referenced
this pull request
Jun 1, 2023
…3.7.x Backport PR #26005 on branch v3.7.x (Fix backend tests on CI)
Member
Author
|
Backport is in #26021. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #25988 by skipping that version of PySide6, and fixes the Azure macOS build by xfailing the tests as in #23095.
PR checklist