Get rcParams from mpl - #23678
Merged
Merged
Conversation
oscargus
force-pushed
the
rcparamsimport
branch
from
August 19, 2022 14:28
618396d to
24c9cb9
Compare
Member
|
Use |
timhoffm
approved these changes
Aug 19, 2022
Member
Author
|
OK! Then there are a few more files to change. |
oscargus
marked this pull request as draft
August 19, 2022 15:21
oscargus
force-pushed
the
rcparamsimport
branch
from
August 19, 2022 16:05
24c9cb9 to
ea189d0
Compare
oscargus
marked this pull request as ready for review
August 19, 2022 16:06
oscargus
force-pushed
the
rcparamsimport
branch
from
August 19, 2022 16:07
ea189d0 to
e7ac698
Compare
Member
Author
|
I have changed "all" instances. In pyplot it is still imported. Some tests, use plt.rcParams, which seems to be on purpose and some should probably be changed to use rcContext. But with respect to this PR I am happy for now. |
oscargus
force-pushed
the
rcparamsimport
branch
from
August 19, 2022 16:14
e7ac698 to
f1e3a76
Compare
oscargus
force-pushed
the
rcparamsimport
branch
from
August 19, 2022 16:18
f1e3a76 to
438d30b
Compare
timhoffm
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Realized that this was quite inconsistent. It is still not really consistent, but I doubted half-ways that there is a preferred way...
Related to #23680 (almost closes it...)
So, is there are preferred way among
and
?
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).