Skip to content

DOC fixed duplicate/wrong default - #23115

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
davidgilbertson:patch-1
May 24, 2022
Merged

DOC fixed duplicate/wrong default#23115
jklymak merged 1 commit into
matplotlib:mainfrom
davidgilbertson:patch-1

Conversation

@davidgilbertson

Copy link
Copy Markdown
Contributor

Seems that when the docs are generated (here), it outputs the default (which is actually 6) so this bit of text is wrong and redundant.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@oscargus oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense! I'd merge it directly, but since I think it should also be updated ASAP in the stable version, I am not fully sure which milestone to set...

@jklymak jklymak added this to the v3.5-doc milestone May 24, 2022
@jklymak

jklymak commented May 24, 2022

Copy link
Copy Markdown
Member

I think 3.5-doc?

@jklymak
jklymak merged commit 9c5a749 into matplotlib:main May 24, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 24, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 24, 2022
oscargus added a commit that referenced this pull request May 24, 2022
…115-on-v3.5.x

Backport PR #23115 on branch v3.5.x (DOC fixed duplicate/wrong default)
oscargus added a commit that referenced this pull request May 24, 2022
…115-on-v3.5.2-doc

Backport PR #23115 on branch v3.5.2-doc (DOC fixed duplicate/wrong default)
@oscargus oscargus mentioned this pull request May 24, 2022
2 tasks
@oscargus

Copy link
Copy Markdown
Member

Thanks @davidgilbertson and congratulations to your first contribution to Matplotlib! Hope to see you around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants