This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Conversation
jnewman
force-pushed
the
reformat
branch
4 times, most recently
from
February 6, 2015 21:54
0e369a2 to
0a72e91
Compare
- Switch to current code standards - Remove unnecessary imports - Switch quotes - Cleanup newlines - Use nose - Add code coverage - Add testing instructions - Add info about deployments - cover correct package - Rev version
Merged
|
LGTM. In the future I'd rather see code style changes in multiple logical commits (whitespace, quote switching) and things like moving code, removing imports, and adding docs in other commits so it's easier to see what has actually changed. As it is, I'm unlikely to be able to see any subtle issues in this patch. |
jnewman
pushed a commit
that referenced
this pull request
Feb 7, 2015
Switch to current code standards
unrealsolver
pushed a commit
that referenced
this pull request
Aug 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm setting up jenkins jobs for this now, but they need some of these changes to work..