Backport 25.1: Validation cleanup - #4462
Merged
Merged
Conversation
(cherry picked from commit db6f58b)
Contributor
Test Results 326 files 326 suites 4m 48s ⏱️ Results for commit 6f0cb3a. |
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 6f0cb3a. ♻️ This comment has been updated with latest results. |
Contributor
Test ReportTest Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4441 to the
25.xmaintenance branch.The
25.xbranch still uses the rule-based validator, so the same linear fragment-cycle algorithm is applied toNoFragmentCyclesrather than the newerOperationValidator. The original focused coverage is retained.Summary:
Testing:
RELEASE_VERSION=local-test ./gradlew test -x testWithJava11 -x testWithJava17 --tests graphql.validation.rules.NoFragmentCyclesTest(15 tests on Java 21)