Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

added new RobusTest bug commit structure - #882

Closed
omnarayan wants to merge 4 commits into
github:masterfrom
omnarayan:master
Closed

added new RobusTest bug commit structure#882
omnarayan wants to merge 4 commits into
github:masterfrom
omnarayan:master

Conversation

@omnarayan

Copy link
Copy Markdown

No description provided.

Om Narayan and others added 3 commits February 10, 2014 10:12
additional fileds
 * gitsha
 * added
 * removed
 * modified
 * timestamp
 * name
 * email
@kdaigle

kdaigle commented Jun 24, 2014

Copy link
Copy Markdown
Member

It would be really valuable to have a test in place for RobusTest that runs for both the old code and the new code. Since we don't use RobusTest at GitHub, my fear is that this refactoring could introduce a bug and, without tests, we'd have no way or really knowing.

Could you add one potentially that passes for both old and new?

@omnarayan

Copy link
Copy Markdown
Author

I have added unit test for robustest

@kdaigle

kdaigle commented Jun 25, 2014

Copy link
Copy Markdown
Member

@omnarayan thanks! Can you try running this test against master without the changes? I'd really like a test that passes for both implementations if possible to ensure nothing is breaking.

Are you a part of RobusTest as well or just a friendly person building this? It's good to know if you'd like to just override me and can vouch for it working with your service.

@omnarayan

Copy link
Copy Markdown
Author

@kdaigle
Sorry for delay , I ll do testing and update on same.
I am co-founder of RobusTest.

@kdaigle

kdaigle commented Oct 8, 2014

Copy link
Copy Markdown
Member

I'm going to close this but feel free to re-open once you add tests. 👾

@kdaigle kdaigle closed this Oct 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants