fix: correct spec typos and remove dead data - #27
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
- Network/v2.pm: fix 'prokect_id' → 'project_id' typo in ports query spec. This caused project_id filters to be silently ignored at the API level, forcing slower client-side filtering. - Compute/v2_0.pm: add missing /flavors spec (present in v2_1 but absent in v2_0), restoring feature parity between API versions. - Images.pm: remove stale __DATA__ block containing Compute specs (keypairs, flavors) that were copy-pasted from another module and never consumed by the Images service. - New test t/specs-fields.t validates field names across all spec classes against known-good lists and checks for common misspellings. Addresses remaining items from atoomic#18. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix API spec bugs that cause silent filter failures and remove dead data.
Why
The Network v2 ports spec had
prokect_idinstead ofproject_id— a typo that silently preventedproject_idfrom being sent as an API-level query filter. Users filtering ports by project would get results, but via slow client-side filtering instead of efficient server-side filtering.The Compute v2.0 spec was missing the
/flavorsendpoint entirely (present in v2.1), meaning deployments on Compute API v2.0 had noflavors()method available.Images.pm carried a stale
__DATA__block with Compute specs (keypairs, flavors) — dead code from a copy-paste that was never consumed.Addresses remaining items from #18.
How
prokect_id→project_id(line 61)/flavorsspec matching v2_1 parity__DATA__blockt/specs-fields.tvalidates all spec field names against known-good lists and checks for common misspellings — catches this class of typo automaticallyTesting
t/specs-fields.t: 4 subtests, 212+ assertions covering field name validation and typo detection🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 114 insertions(+), 11 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline