fix: delete_server() handles multi-homed VMs - #19
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
The previous code assigned ports() result to a scalar, which returns the
element count when _list() finds multiple matches. This caused a crash
("Can't use string as HASH ref") when deleting VMs with more than one
network port. Now iterates over all ports in list context and cleans up
each associated floating IP.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
delete_server()to properly clean up floating IPs on VMs with multiple network ports.Why
The previous code called
ports(device_id => $uid)in scalar context. The_list()method returns the element count (not a hashref) when multiple results match, causing a fatal "Can't use string as HASH ref" error on multi-homed VMs. Single-port VMs were unaffected.How
Changed from scalar assignment to list context (
my @ports_for_device = ...) and iterate over all ports, cleaning up each associated floating IP. Thenext unless ref $portguard handles the undef case from zero-match results.Testing
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 122 insertions(+), 6 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline