Skip to content

TST: bump mpldev image test references - #19562

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/update-mpldev-hashes
Apr 11, 2026
Merged

TST: bump mpldev image test references#19562
neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/update-mpldev-hashes

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Description

There are 56 image tests currently failing with what appears to be a single pixel-wide diff in where axes ticks and labels are placed. Despite my best efforts1, I couldn't locate the corresponding upstream change, so here I'm working wihtin the assumption that the change was intentional rather than a regression.

@ayshih, would you, by chance, be able to confirm this diagnostic and/or pin point the upstream change ?

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Footnotes

  1. I tried to reproduce the error on a machine I control, and looked for related PRs recently merged upstream.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone Apr 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@ayshih

ayshih commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

These changes should all be due to matplotlib/matplotlib#30161, which overhauled how fonts are rendered. I guess there might be image differences beyond just text if the text changes happen to affect bounds calculations for a given plot.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Excellent. Thanks a lot !
I took another look and

  • all diff seem purely textual
  • they're not always as subtle as a single pix diff
  • the biggest one is the following
Screenshot 2026-04-11 at 13 47 29

@neutrinoceros
neutrinoceros marked this pull request as ready for review April 11, 2026 11:49
@neutrinoceros neutrinoceros added the Affects-dev PRs and issues that do not impact an existing Astropy release label Apr 11, 2026
@neutrinoceros neutrinoceros modified the milestones: v8.0.0, v7.2.1 Apr 11, 2026
@neutrinoceros neutrinoceros added 🔥 Critical backport-v7.2.x on-merge: backport to v7.2.x labels Apr 11, 2026
@neutrinoceros
neutrinoceros merged commit ea7889c into astropy:main Apr 11, 2026
77 of 82 checks passed
@neutrinoceros
neutrinoceros deleted the tst/update-mpldev-hashes branch April 11, 2026 14:48
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v7.2.x on-merge: backport to v7.2.x 🔥 Critical no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants