feat(router): add containsTree as public API - #70148
Conversation
atscott
left a comment
There was a problem hiding this comment.
Hmmm, I guess I don't see any reason we can't do this. It's effectively public API already through isActive. That said, I wonder if it would be better to pull down the default patch options here rather than combining them above in isActive. Otherwise you would be required to define them fully when calling this function, which was a pain before.
a150669 to
403bc43
Compare
Thanks for the feedback. Pushed changes making options optional and setting default fallback options |
Export containsTree from @angular/router to enable direct UrlTree subset matching.
4560f36 to
c7628c8
Compare
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-apii
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Export containsTree from @angular/router to enable direct UrlTree subset matching.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
containsTree()was not included in public API for comparing URLsIssue Number: #53129
What is the new behavior?
containsTree()from @angular/router to allow developers to perform directUrlTreesubset matchingDoes this PR introduce a breaking change?
Other information