From 8c9d71cfc487b4288d389406524b2cab69e53392 Mon Sep 17 00:00:00 2001 From: Julien Palard Date: Tue, 26 Dec 2017 23:00:28 +0100 Subject: [PATCH] bpo-32429: Abort compilation on outdated Modules/Setup file. --- Makefile.pre.in | 3 +++ .../NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst | 3 +++ 2 files changed, 6 insertions(+) create mode 100644 Misc/NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst diff --git a/Makefile.pre.in b/Makefile.pre.in index 4fe9affe0d25e9e..8a81b2cdd55d637 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -692,7 +692,10 @@ Modules/Setup: $(srcdir)/Modules/Setup.dist echo "check to make sure you have all the updates you"; \ echo "need in your Modules/Setup file."; \ echo "Usually, copying Modules/Setup.dist to Modules/Setup will work."; \ + echo "Or if you want to keep your modifications, touch Modules/Setup"; \ + echo "to skip this warning."; \ echo "-----------------------------------------------"; \ + false; \ fi Programs/_testembed: Programs/_testembed.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) diff --git a/Misc/NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst b/Misc/NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst new file mode 100644 index 000000000000000..7297d1f83c156df --- /dev/null +++ b/Misc/NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst @@ -0,0 +1,3 @@ +Build will now fail when Module/Setup is out of date. Previously a warning +was displayed but was invisible due to make verbosity, sometimes giving a +non-working Python as a result, like in https://bugs.python.org/issue32335.