From e0cfc07ebb77dd56eb1d1726f4381102e97f8718 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Wed, 22 Jan 2020 23:00:46 -0500 Subject: [PATCH 1/2] Modify existing NEWS.txt entry. --- Lib/idlelib/NEWS.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 69bf5603068d64..708292ebee9f1c 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -6,7 +6,8 @@ Released on 2020-10-05? bpo-39050: Make Settings dialog Help button work again. bpo-32989: Add tests for editor newline_and_indent_event method. -Remove dead code from pyparse find_good_parse_start method. +Remove unneeded arguments and dead code from pyparse +find_good_parse_start method. bpo-38943: Fix autocomplete windows not always appearing on some systems. Patch by Johnny Najera. From 7ebbd8c6fb78c4e15d24394e1d4cde801a2170fe Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Wed, 22 Jan 2020 23:27:42 -0500 Subject: [PATCH 2/2] bpo-32989: IDLE - remove unneeded parameter IDLE does not pass a non-default _synchre in any of its calls to pyparse.find_good_parse_start. --- Lib/idlelib/pyparse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/idlelib/pyparse.py b/Lib/idlelib/pyparse.py index 9fa20108960711..d34872b4396e1e 100644 --- a/Lib/idlelib/pyparse.py +++ b/Lib/idlelib/pyparse.py @@ -133,7 +133,7 @@ def set_code(self, s): self.code = s self.study_level = 0 - def find_good_parse_start(self, is_char_in_string, _synchre=_synchre): + def find_good_parse_start(self, is_char_in_string): """ Return index of a good place to begin parsing, as close to the end of the string as possible. This will be the start of some