Skip to content

Email enumeration protection related error and doc updates - #12081

Merged
renkelvin merged 7 commits into
masterfrom
invalid-login-cred
Nov 17, 2023
Merged

Email enumeration protection related error and doc updates#12081
renkelvin merged 7 commits into
masterfrom
invalid-login-cred

Conversation

@renkelvin

Copy link
Copy Markdown
Contributor
  1. Add support of INVALID_LOGIN_CREDENTIALS error.
  2. Update ref docs for several apis.

@renkelvin
renkelvin requested a review from prameshj November 8, 2023 23:21
@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

✅  No API diff detected

Commit: 642e77f
Last updated: Wed Nov 15 12:42 PST 2023
View workflow logs & download artifacts


@google-oss-bot

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot

google-oss-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.53% (a0fcb67) to 68.52% (642e77f) by -0.01%.

    FilenameBase (a0fcb67)Merge (642e77f)Diff
    FIRAuthBackend.m81.92%81.93%+0.02%
    FIRAuthKeychainServices.m59.66%58.80%-0.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dlrJepLNFy.html

Comment thread FirebaseAuth/Sources/Backend/FIRAuthBackend.m Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthErrors.h Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRUser.h Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthErrors.h Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRUser.h Outdated
Comment thread FirebaseAuth/Tests/Unit/FIRAuthTests.m Outdated
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h
renkelvin added 6 commits November 15, 2023 11:27
Remove deprecated swift tests since there is no way to surpass warnings in swift

Revert "Remove deprecated swift tests since there is no way to surpass warnings in swift"

This reverts commit e49c948.

Revert "Update FIRAuth.h"

This reverts commit 358020d.

Revert "Revert "Update FIRAuth.h""

This reverts commit c800109c56d671c68d573fef9f7d694299f6a2a7.

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG update for the public API changes

Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRUser.h
Comment thread FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuth.h
@firebase firebase locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants