Add FIID and new proto fields to Crashlytics - #10645
Merged
Merged
Conversation
Collaborator
Size Report 1Affected ProductsTest Logs |
visumickey
reviewed
Jan 5, 2023
visumickey
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me!
| // so that the payload has an updated value. | ||
| [self.installIDModel regenerateInstallIDIfNeeded]; | ||
| [self.installIDModel regenerateInstallIDIfNeededWithBlock:^(NSString *_Nonnull newFIID) { | ||
| self.fiid = [newFIID copy]; |
Contributor
There was a problem hiding this comment.
Why explicitly copy when the property is already qualified as "Copy"?
Contributor
Author
There was a problem hiding this comment.
It's kindof a funny thing, but the style guide suggests you copy strings when you don't know where they came from: https://google.github.io/styleguide/objcguide.html#setters-copy-nsstrings. The main thing is to avoid cases of it being mutable under the hood or having different retain semantics than what you expect.
Contributor
There was a problem hiding this comment.
Interesting. Surprisingly their example is a on an override setter method which makes it even more weird. Since there is no harm in re-copying, I'm fine with this change.
themiswang
reviewed
Jan 5, 2023
visumickey
approved these changes
Jan 5, 2023
samedson
force-pushed
the
crashlytics-fiid
branch
from
January 9, 2023 18:02
99f90ea to
b85c01c
Compare
themiswang
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of collaborating with the Sessions SDK, Crashlytics will need Firebase Install IDs for consistency. Crashlytics has its own Installation UUID but it does not align with the FIID.