Message 342025 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	Paul Monson, eryksun, methane, paul.moore, serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware
Date	2019-05-10.01:12:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557450736.43.0.591813146796.issue36778@roundup.psfhosted.org>
In-reply-to

Content
> I dislike lying in the locale module. This change is basically useless with my PR 13230. Note that Python produce "cpNNN" encoding name, not Windows. https://github.com/python/cpython/blob/137be34180a20dba53948d126b961069f299f153/Modules/_localemodule.c#L395 So I don't think it is lie. It is just "what encoding name we should choose when GetACP() returned 65001.". With your PR 13230, cp65001 is truly utf-8. So returning "utf-8" seems right behavior.

> I dislike lying in the locale module. This change is basically useless with my PR 13230.


Note that Python produce "cpNNN" encoding name, not Windows.
https://github.com/python/cpython/blob/137be34180a20dba53948d126b961069f299f153/Modules/_localemodule.c#L395

So I don't think it is lie.  It is just "what encoding name we should choose when GetACP() returned 65001.".
With your PR 13230, cp65001 is truly utf-8.  So returning "utf-8" seems right behavior.

History
Date	User	Action	Args
2019-05-10 01:12:16	methane	set	recipients: + methane, paul.moore, vstinner, tim.golden, zach.ware, serhiy.storchaka, eryksun, steve.dower, Paul Monson
2019-05-10 01:12:16	methane	set	messageid: <1557450736.43.0.591813146796.issue36778@roundup.psfhosted.org>
2019-05-10 01:12:16	methane	link	issue36778 messages
2019-05-10 01:12:16	methane	create