Skip to content

[TEMP] bpo-11105: use PY_LOCAL()s for AST converter functions #26554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidentical wants to merge 1 commit into from
Closed

[TEMP] bpo-11105: use PY_LOCAL()s for AST converter functions #26554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Parser/asdl_c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def recursive_call(self, node, level):

def funcHeader(self, name):
ctype = get_c_type(name)
self.emit("int", 0)
self.emit("Py_LOCAL_INLINE(int)", 0)
self.emit("obj2ast_%s(struct ast_state *state, PyObject* obj, %s* out, PyArena* arena)" % (name, ctype), 0)
self.emit("{", 0)
self.emit("int isinstance;", 1)
Expand Down Expand Up @@ -514,7 +514,7 @@ def visitSum(self, sum, name):

def visitProduct(self, prod, name):
ctype = get_c_type(name)
self.emit("int", 0)
self.emit("Py_LOCAL_INLINE(int)", 0)
self.emit("obj2ast_%s(struct ast_state *state, PyObject* obj, %s* out, PyArena* arena)" % (name, ctype), 0)
self.emit("{", 0)
self.emit("PyObject* tmp = NULL;", 1)
Expand Down Expand Up @@ -1434,6 +1434,11 @@ def generate_module_def(mod, f, internal_h):
generate_ast_state(module_state, internal_h)

print(textwrap.dedent("""
/* enable more aggressive intra-module optimizations, where available
to reduce the stack usage for windows. */

#define PY_LOCAL_AGGRESSIVE

#include "Python.h"
#include "pycore_ast.h"
#include "pycore_ast_state.h" // struct ast_state
Expand Down
41 changes: 23 additions & 18 deletions Python/Python-ast.c
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.