[3.13] gh-69371: Fix pydoc for modules whose path contains undecodable bytes (GH-155239) - #156610
Open
miss-islington wants to merge 1 commit into
Open
[3.13] gh-69371: Fix pydoc for modules whose path contains undecodable bytes (GH-155239)#156610miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
… bytes (pythonGH-155239) "python -m pydoc -w" and the pydoc HTTP server failed with UnicodeEncodeError. The file URL is now created with urllib.request.pathname2url(), which percent-encodes the path using the filesystem encoding, and characters unencodable in the generated UTF-8 page are escaped with backslashes. (cherry picked from commit c8ca336) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 29, 2026
serhiy-storchaka
enabled auto-merge (squash)
August 29, 2026 20:04
Member
|
Windows is failing with ======================================================================
ERROR: test_html_doc_undecodable_path (test.test_pydoc.test_pydoc.PydocDocTest.test_html_doc_undecodable_path)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_pydoc\test_pydoc.py", line 1022, in test_html_doc_undecodable_path
doc = pydoc.HTMLDoc().docmodule(mod)
File "D:\a\cpython\cpython\Lib\pydoc.py", line 849, in docmodule
url = urllib.request.pathname2url(path)
File "D:\a\cpython\cpython\Lib\nturl2path.py", line 68, in pathname2url
tail = urllib.parse.quote(comp[1])
File "D:\a\cpython\cpython\Lib\urllib\parse.py", line 923, in quote
string = string.encode(encoding, errors)
UnicodeEncodeError: 'utf-8' codec can't encode character '\udd00' in position 65: surrogates not allowed
|
StanFromIreland
disabled auto-merge
August 31, 2026 13:12
Member
|
CC @serhiy-storchaka (see Hugo's comment above). |
This was referenced Aug 31, 2026
Member
|
This is a little complicated. Applying the similar fix on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"python -m pydoc -w" and the pydoc HTTP server failed with
UnicodeEncodeError. The file URL is now created with
urllib.request.pathname2url(), which percent-encodes the path using the
filesystem encoding, and characters unencodable in the generated UTF-8
page are escaped with backslashes.
(cherry picked from commit c8ca336)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
Co-authored-by: Claude Opus 5 (1M context) noreply@anthropic.com