Skip to content

gh-107559: Argument Clinic: complain about non-ascii chars in param docstrings - #107560

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:clinic/improve-non-ascii-msg
Aug 2, 2023
Merged

gh-107559: Argument Clinic: complain about non-ascii chars in param docstrings#107560
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:clinic/improve-non-ascii-msg

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

…aram docstrings

Also, improve the warn() message.
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Do you want to backport this?

Comment thread Lib/test/test_clinic.py Outdated
with support.captured_stdout() as stdout:
self.parse(block)
# Only the first match is shown.
# Also, the line numbers are off; this is a known limitation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to address that limitation in the error handling rewrite.

@AlexWaygood

AlexWaygood commented Aug 2, 2023

Copy link
Copy Markdown
Member

Do you want to backport this?

I'll leave it to you to decide — it's strictly speaking a bugfix, so we could, but it's also a bug that people are pretty unlikely to hit in practice (and I don't know how many people actually use clinic from older branches of CPython anyway...). So maybe not worth the churn.

Comment thread Tools/clinic/clinic.py Outdated
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

I'll leave it to you to decide — it's strictly speaking a bugfix, so we could, but it's also a bug that people are pretty unlikely to hit in practice (and I don't know how many people actually use clinic from older branches of CPython anyway...). So maybe not worth the churn.

We'll see if 🧙‍♀️ can handle it. If she can't, we won't bother.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 2, 2023 11:59
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 2, 2023
@erlend-aasland
erlend-aasland merged commit 9ff7b4a into python:main Aug 2, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9ff7b4af137b8028b04b52addf003c4b0607113b 3.12

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9ff7b4af137b8028b04b52addf003c4b0607113b 3.11

@erlend-aasland
erlend-aasland deleted the clinic/improve-non-ascii-msg branch August 2, 2023 12:40
@erlend-aasland erlend-aasland removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants