Fix non-null union field implements nullable union interface field - #4467
Open
tonyghita wants to merge 1 commit into
Open
Fix non-null union field implements nullable union interface field#4467tonyghita wants to merge 1 commit into
tonyghita wants to merge 1 commit into
Conversation
Author
|
Alternatively we could always unwrap non-null first? |
Member
|
Have not looked into it further, but what about nullability inside list and list of lists? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec IsValidImplementationFieldType(), concrete type fields are able to strengthen the nullability guarantees made by an interface type field.
This mostly happens except when the field is a Union type.
This change adds a check for
objectType instanceOf GraphQLObjectTypeso that non-null unions fall-through to the unwrap case first.