From 3db0725e6102b51dba19b1f07bc358551f41890a Mon Sep 17 00:00:00 2001 From: Luan Taraschi <130802253+luantaraschi@users.noreply.github.com> Date: Thu, 20 Aug 2026 21:32:11 -0300 Subject: [PATCH] Drop the lint expectations clippy 1.98 no longer fulfils `clippy::std_instead_of_core` stopped firing at the four places that carry an `#[expect]` for it. All four were added for the same false positive, on items whose `core` counterpart is still unstable. `unfulfilled_lint_expectations` is denied through `-D warnings`, so the three clippy jobs and the WASM check fail on current stable for every pull request, whatever it touches. Assisted-by: Claude Code:claude-opus-5 --- crates/host_env/src/fileutils.rs | 4 ---- crates/stdlib/src/pyexpat.rs | 3 --- crates/stdlib/src/ssl.rs | 3 --- crates/vm/src/stdlib/_io.rs | 4 ---- 4 files changed, 14 deletions(-) diff --git a/crates/host_env/src/fileutils.rs b/crates/host_env/src/fileutils.rs index 9d7e4430681..affb6d2205b 100644 --- a/crates/host_env/src/fileutils.rs +++ b/crates/host_env/src/fileutils.rs @@ -445,10 +445,6 @@ pub unsafe fn fclose(fp: *mut CFile) -> core::ffi::c_int { // _Py_fopen_obj in cpython (Python/fileutils.c:1757-1835) // Open a file using std::fs::File and convert to FILE* // Automatically handles path encoding and EINTR retries -#[expect( - clippy::std_instead_of_core, - reason = "false positive: core::io::ErrorKind is unstable (core_io)" -)] pub fn fopen(path: &std::path::Path, mode: &str) -> std::io::Result<*mut CFile> { use std::fs::File; diff --git a/crates/stdlib/src/pyexpat.rs b/crates/stdlib/src/pyexpat.rs index 9b55bbb22f3..500a8a686c8 100644 --- a/crates/stdlib/src/pyexpat.rs +++ b/crates/stdlib/src/pyexpat.rs @@ -1,8 +1,5 @@ //! Pyexpat builtin module -// false positive: core::io::Cursor is unstable (core_io), unusable on stable -#![expect(clippy::std_instead_of_core)] - // spell-checker: ignore libexpat pub(crate) use _pyexpat::module_def; diff --git a/crates/stdlib/src/ssl.rs b/crates/stdlib/src/ssl.rs index 262c3936e0a..c99ec024fa3 100644 --- a/crates/stdlib/src/ssl.rs +++ b/crates/stdlib/src/ssl.rs @@ -13,9 +13,6 @@ //! //! Warning: This library contains AI-generated code and comments. Do not trust any code or comment without verification. Please have a qualified expert review the code and remove this notice after review. -// false positive: core::io::{Cursor, ErrorKind} are unstable (core_io), unusable on stable -#![expect(clippy::std_instead_of_core)] - // OID (Object Identifier) management module mod oid; diff --git a/crates/vm/src/stdlib/_io.rs b/crates/vm/src/stdlib/_io.rs index 4db5fb760c1..08dd0e0ef80 100644 --- a/crates/vm/src/stdlib/_io.rs +++ b/crates/vm/src/stdlib/_io.rs @@ -113,10 +113,6 @@ impl std::os::fd::AsRawFd for Fildes { } #[pymodule] -#[expect( - clippy::std_instead_of_core, - reason = "false positive: core::io items (Cursor, etc.) are unstable (core_io)" -)] mod _io { use super::*; use crate::{